Skip to content

A new serverless function doesn't appear in os view if created not in ws folder #3255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msivasubramaniaan merged 3 commits into from
Sep 13, 2023
Merged

A new serverless function doesn't appear in os view if created not in ws folder #3255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c72eb89
initial commit
msivasubramaniaan Sep 8, 2023
6f44676
Merge branch 'main' into 3136-a-new-serverless-function-doesnt-appear…
msivasubramaniaan Sep 11, 2023
7607133
check func.yaml recursively under workspace sub folder
msivasubramaniaan Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/serverlessFunction/functionModel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,12 @@ export class ServerlessFunctionModel implements Disposable {
const folders: Uri[] = [];
if (workspace.workspaceFolders) {
for (const wf of workspace.workspaceFolders) {
const entries = await fs.readdir(wf.uri.fsPath, { withFileTypes: true });
for (const file of entries) {
if (file.isDirectory() && fs.existsSync(path.join(wf.uri.fsPath, file.name, 'func.yaml'))) {
folders.push(Uri.file(path.join(wf.uri.fsPath, file.name)));
}
}
if (fs.existsSync(path.join(wf.uri.fsPath, 'func.yaml'))) {
folders.push(wf.uri);
}
Expand Down
2 changes: 1 addition & 1 deletion src/webview/serverless-function/serverlessFunctionLoader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ async function messageListener(panel: vscode.WebviewPanel, event: any): Promise<
let response: CliExitData;
const eventName = event.action;
const functionName = event.name;
const functionPath: vscode.Uri = event.folderPath ? vscode.Uri.from(event.folderPath) : undefined;
const functionPath: vscode.Uri = event.folderPath;
switch (eventName) {
case 'validateName':
const flag = validateName(functionName);
Expand Down
⚡