Remove the use of webview for describe and logs as replaced by OS Ter…#3500
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Oct 31, 2023
Conversation
…minal This commit completely removes the use of LazyLog-based webviews previously used to display the contents of component describe and show/follow log functionality. The "openshiftToolkit.useWebviewInsteadOfTerminalView" configuration preference is also removed as well as all its usages. Fixes: redhat-developer#1803 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3500 +/- ##
=======================================
Coverage 35.07% 35.07%
=======================================
Files 78 76 -2
Lines 5634 5579 -55
Branches 1114 1109 -5
=======================================
- Hits 1976 1957 -19
+ Misses 3658 3622 -36
☔ View full report in Codecov by Sentry. |
datho7561
approved these changes
Oct 31, 2023
Contributor
datho7561
left a comment
datho7561
left a comment
There was a problem hiding this comment.
Looks good. Thanks, Victor!
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
Oct 31, 2023
Removing the unused dependencies left after merging the PR redhat-developer#3500 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
that referenced
this pull request
Oct 31, 2023
Removing the unused dependencies left after merging the PR #3500 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
vrubezhny
added a commit
to vrubezhny/vscode-openshift-tools
that referenced
this pull request
Dec 7, 2023
We don't need this dependency anymore, as it was used in src/webview/log/app/spinner.tsx which was completely removed in redhat-developer#3500. Supercedes redhat-developer#3705 Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…minal
This commit completely removes the use of LazyLog-based webviews previously used to display the contents of component describe and show/follow log functionality.
The "openshiftToolkit.useWebviewInsteadOfTerminalView" configuration preference is also removed as well as all its usages.
Fixes: #1803