update settings.json for setting default formatter as yaml on docker compose and github actions#1126
Closed
msivasubramaniaan wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
Contributor
|
Is this needed to address the bug? Formatting in Without this change, if the user has both prettier and vscode-yaml installed, when they activate formatting on a |
|
The problem is that the file is NOT detected as YAML, when Docker DX or other similar extension is installed. Thus the formatter is not activated. |
Contributor
|
/facepalm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR will make vscode-yaml as default formatter for docker compose and github actions. Will do one more PR on client side as well
What issues does this PR fix or reference?
redhat-developer/yaml-language-server#1071
Is it tested? How?
Yes with existing test case