Skip to content

update settings.json for setting default formatter as yaml on docker compose and github actions#1126

Closed
msivasubramaniaan wants to merge 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:fix-yaml-as-default-formatter-on-compose-and-github_actions
Closed

update settings.json for setting default formatter as yaml on docker compose and github actions#1126
msivasubramaniaan wants to merge 1 commit intoredhat-developer:mainfrom
msivasubramaniaan:fix-yaml-as-default-formatter-on-compose-and-github_actions

Conversation

@msivasubramaniaan
Copy link
Copy Markdown
Contributor

What does this PR do?

This PR will make vscode-yaml as default formatter for docker compose and github actions. Will do one more PR on client side as well

What issues does this PR fix or reference?

redhat-developer/yaml-language-server#1071

Is it tested? How?

Yes with existing test case

Signed-off-by: msivasubramaniaan <msivasub@redhat.com>
@msivasubramaniaan msivasubramaniaan self-assigned this May 19, 2025
@datho7561
Copy link
Copy Markdown
Contributor

Is this needed to address the bug? Formatting in docker-compose.yaml seems to work fine for me with just redhat-developer/yaml-language-server#1077 .

Without this change, if the user has both prettier and vscode-yaml installed, when they activate formatting on a docker-compose.yaml file, it will prompt them to pick between the two. I think prompting them to pick is more helpful, since if they have prettier installed they might prefer that.

@AnrDaemon
Copy link
Copy Markdown

The problem is that the file is NOT detected as YAML, when Docker DX or other similar extension is installed. Thus the formatter is not activated.

[Window Title]
Visual Studio Code

[Content]
There is no formatter for 'dockercompose' files installed.

[Install Formatter...] [Cancel]

@datho7561
Copy link
Copy Markdown
Contributor

This change was accidentally included as a part of #1131. After the release, users reported it as a bug: #1157. So I reverted it in #1159. I don't think we should make this change, it seems to annoy users.

@datho7561 datho7561 closed this Oct 1, 2025
@AnrDaemon
Copy link
Copy Markdown

/facepalm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants