Skip to content

Revert "update settings.json as default formatter as yaml"#1159

Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:do-not-update-user-formatter-settings
Sep 30, 2025
Merged

Revert "update settings.json as default formatter as yaml"#1159
datho7561 merged 1 commit intoredhat-developer:mainfrom
datho7561:do-not-update-user-formatter-settings

Conversation

@datho7561
Copy link
Copy Markdown
Contributor

@datho7561 datho7561 commented Sep 29, 2025

What does this PR do?

This reverts commit 84d4516.

Adjusting the user settings automatically was annoying to some users. The main bug fix, which consisted of setting the document selector to include Docker Compose and GitHub Action files, will not be reverted.

What issues does this PR fix or reference?

Fixes #1157

Is it tested? How?

I manually tested to make sure the settings aren't updated after this change

This reverts commit 84d4516.

Fixes redhat-developer#1157

Adjusting the user settings automatically was annoying to some users.
The main bug fix, which consisted of setting the document selector to
include Docker Compose and GitHub Action files,
will not be reverted.
@datho7561 datho7561 merged commit ef16f01 into redhat-developer:main Sep 30, 2025
2 of 3 checks passed
@datho7561 datho7561 deleted the do-not-update-user-formatter-settings branch September 30, 2025 13:12
@datho7561
Copy link
Copy Markdown
Contributor Author

@harmathy @ejpcmac tomorrow at 8 AM UTC there should (hopefully) be a prerelease of vscode-yaml that contains the fix.

If you want to try out the prerelease tomorrow, you will need to open the vscode-yaml page in the extension marketplace, then press the button labelled "Switch to Pre-Release Version": (this photo shows vscode-xml since vscode-yaml doesn't have this button available until the prerelease is published):

big red arrow pointing to the switch to pre-release button, which is to the right of the uninstall and disable buttons

@datho7561
Copy link
Copy Markdown
Contributor Author

@harmathy @ejpcmac I manually built the prerelease, so it should be available now (the automatic nightly build failed due to bugs in the release pipeline)

@harmathy
Copy link
Copy Markdown

harmathy commented Oct 4, 2025

@datho7561 I tested 1.20.2025100113 and can confirm that #1157 is fixed with this version. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Settings Changed

2 participants