Skip to content

Revert "update settings.json as default formatter as yaml" #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
datho7561 merged 1 commit into from
Sep 30, 2025
+2 −21
Merged

Revert "update settings.json as default formatter as yaml" #1159

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 2 additions & 21 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*--------------------------------------------------------------------------------------------*/
'use strict';

import { workspace, ExtensionContext, extensions, window, commands, Uri, ConfigurationTarget } from 'vscode';
import { workspace, ExtensionContext, extensions, window, commands, Uri } from 'vscode';
import {
CommonLanguageClient,
LanguageClientOptions,
Expand Down Expand Up @@ -161,7 +161,7 @@ export function startClient(
findConflicts();
client
.onReady()
.then(async () => {
.then(() => {
// Send a notification to the server with any YAML schema associations in all extensions
client.sendNotification(SchemaAssociationNotification.type, getSchemaAssociations());

Expand Down Expand Up @@ -218,8 +218,6 @@ export function startClient(
});

initializeRecommendation(context);

await setDefaultFormatter(['dockercompose', 'github-actions-workflow']);
})
.catch((err) => {
sendStartupTelemetryEvent(runtime.telemetry, false, err);
Expand All @@ -228,23 +226,6 @@ export function startClient(
return schemaExtensionAPI;
}

/**
* set redhat.vscode-yaml as default formatter
* @param extensions [dockercompose, github-actions-workflow]
*/
async function setDefaultFormatter(extensions: string[]): Promise<void> {
const config = workspace.getConfiguration();
extensions.forEach(async (extension) => {
const extensionConf = config.get<Record<string, string>>(`[${extension}]`) || {};
if (extensionConf) {
if (extensionConf['editor.defaultFormatter'] === undefined) {
extensionConf['editor.defaultFormatter'] = 'redhat.vscode-yaml';
await config.update(`[${extension}]`, extensionConf, ConfigurationTarget.Global);
}
}
});
}

/**
* Finds extensions that conflict with VSCode-YAML.
* If one or more conflicts are found then show an uninstall notification
Expand Down
Loading
⚡