Revert "Address 'no scope' warning"#1203
Merged
datho7561 merged 1 commit intoredhat-developer:mainfrom Mar 3, 2026
Merged
Conversation
shin19991207
approved these changes
Mar 2, 2026
Member
shin19991207
left a comment
shin19991207
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks, David!
This reverts commit d17039f. Sending 'null' goes against the LSP spec, so it only works with VS Code and LSP clients that are replicating this behaviour. (i.e. VS Code and neovim work, but emacs, helix, and many other clients don't) Fixes redhat-developer#1201, fixes redhat-developer#1202
datho7561
force-pushed
the
1201-revert-sending-null-string-as-scope
branch
from
76644ec to
9316f9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This reverts commit d17039f.
Sending 'null' goes against the LSP spec, so it only works with VS Code and LSP clients that are replicating this behaviour. (i.e. VS Code and neovim work, but emacs, helix, and many other clients don't)
What issues does this PR fix or reference?
Fixes #1201, fixes #1202
Is it tested? How?
CI