Issue 118 null literals#241
Merged
JPinkney merged 3 commits intoredhat-developer:masterfrom Mar 15, 2020
timofriedlberlin:issue-118-null-literals
Merged
Issue 118 null literals#241JPinkney merged 3 commits intoredhat-developer:masterfrom timofriedlberlin:issue-118-null-literals
JPinkney merged 3 commits intoredhat-developer:masterfrom
timofriedlberlin:issue-118-null-literals
Conversation
JPinkney
suggested changes
Feb 25, 2020
Contributor
|
@itowlson Just wanted to cc you in on this because I think the kubernetes schema would need to be updated. In cases in the kubernetes schema where a value can be a null or string you'll have to update the type. Currently, |
JPinkney
approved these changes
Feb 26, 2020
Author
|
Just out of interest, when will this be released and upstreamed to vscode-yaml? |
Contributor
|
@timo-klarshift Probably in a couple of weeks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR parses Null literals correctly and stated by the YAML spec: https://yaml.org/type/null.html