Skip to content

Issue 118 null literals#241

Merged
JPinkney merged 3 commits intoredhat-developer:masterfrom
timofriedlberlin:issue-118-null-literals
Mar 15, 2020
Merged

Issue 118 null literals#241
JPinkney merged 3 commits intoredhat-developer:masterfrom
timofriedlberlin:issue-118-null-literals

Conversation

@timofriedlberlin
Copy link
Copy Markdown

@timofriedlberlin timofriedlberlin commented Feb 25, 2020

This PR parses Null literals correctly and stated by the YAML spec: https://yaml.org/type/null.html

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 25, 2020

Coverage Status

Coverage increased (+0.2%) to 77.275% when pulling 003e8fc on timo-klarshift:issue-118-null-literals into 0b6739e on redhat-developer:master.

Comment thread test/schemaValidation.test.ts Outdated
Comment thread src/languageservice/parser/yamlParser07.ts Outdated
@JPinkney
Copy link
Copy Markdown
Contributor

@itowlson Just wanted to cc you in on this because I think the kubernetes schema would need to be updated. In cases in the kubernetes schema where a value can be a null or string you'll have to update the type.

Currently, null is parsed as a string but that violates the yaml spec so its going to go back to parsing null as a NullAstNode and now null will match json schemas "type": "null"

@timofriedlberlin
Copy link
Copy Markdown
Author

Just out of interest, when will this be released and upstreamed to vscode-yaml?

@JPinkney
Copy link
Copy Markdown
Contributor

JPinkney commented Feb 27, 2020

@timo-klarshift Probably in a couple of weeks

@JPinkney JPinkney merged commit 62fa41c into redhat-developer:master Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants