Provide completion for schema ids in modeline #560#566
Closed
apupier wants to merge 1 commit intoredhat-developer:mainfrom
Closed
Provide completion for schema ids in modeline #560#566apupier wants to merge 1 commit intoredhat-developer:mainfrom
apupier wants to merge 1 commit intoredhat-developer:mainfrom
Conversation
apupier
commented
Oct 26, 2021
| textDocument: testTextDocument, | ||
| }); | ||
| assert.strictEqual(result.items.length, 1, `Expecting 1 item in completion but found ${result.items.length}`); | ||
| assert.strictEqual(result.items[0].label, 'http://google.com/'); |
Member
Author
There was a problem hiding this comment.
the only registered schema id is http://google.com/. This sounds strange, is it something done for the whole test suite? Any ideas to improve the test? Maybe register another schema id?
potential improvements: - support range when there is already a value provided - provide completion for local yaml schema files Extracted a specific file for modeline related things. fixes redhat-developer#560 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
apupier
force-pushed
the
560-completionForSchemas
branch
from
f2e826e to
7a8a078
Compare
Member
Author
|
betterly handled by #573 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
potential improvements:
Extracted a specific file for modeline related things.
What does this PR do?
Provide completion for schema ids in modeline. So when we have
# yaml-language-server: $schema=What issues does this PR fix or reference?
fixes #560
Is it tested? How?
i wasn't abel to test the yaml-language-server