Completion schema URI in modeline comment#573
Merged
evidolob merged 4 commits intoredhat-developer:mainfrom Nov 10, 2021
Merged
Completion schema URI in modeline comment#573evidolob merged 4 commits intoredhat-developer:mainfrom
evidolob merged 4 commits intoredhat-developer:mainfrom
Conversation
potential improvements: - support range when there is already a value provided - provide completion for local yaml schema files Extracted a specific file for modeline related things. fixes redhat-developer#560 Signed-off-by: Aurélien Pupier <apupier@redhat.com>
…/yaml-language-server into apupier-560-completionForSchemas
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Collaborator
Author
|
To get this working, I need to change https://github.com/redhat-developer/vscode-yaml/blob/main/language-configuration.json#L37 |
Collaborator
Author
|
As redhat-developer/vscode-yaml#634 merged, this PR should work. |
apupier
approved these changes
Nov 8, 2021
Member
apupier
left a comment
apupier
left a comment
There was a problem hiding this comment.
Despite I was not able to test locally (for general reasons, not specific to this PR), reading code and seeing the screenshot leads me to think that it is a good PR.
JPinkney
approved these changes
Nov 9, 2021
…er into completion-modeline-comment Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Completion schema URI in modeline comment, based on #566
What issues does this PR fix or reference?
none
Is it tested? How?
with tests