Some more progress towards recipe v1 minimigrators#3783
Conversation
Move the inline test recipes from `test_cross_compile` to individual files, in order to make them more maintainable. This will also make it easier to add v1 variations.
beckermr
left a comment
There was a problem hiding this comment.
When moving around recipes, please be careful that the tests of the recipe parser still find all of the examples. I'll look closer later.
|
This line here in particular is what I am concerned about: https://github.com/regro/cf-scripts/blob/main/tests/test_recipe_parser.py#L1612 |
Codecov ReportAttention: Patch coverage is
❌ Your project status has failed because the head coverage (94.05%) is below the target coverage (95.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #3783 +/- ##
==========================================
- Coverage 77.39% 75.90% -1.50%
==========================================
Files 134 134
Lines 14845 14842 -3
==========================================
- Hits 11490 11266 -224
- Misses 3355 3576 +221 ☔ View full report in Codecov by Sentry. |
Ah, sorry, didn't expect that. Do you prefer that I move them back to top-level, or modify this test to look recursively? |
|
We should modify the list to look recursively. |
|
Thank you! |
Description:
Cos7Configon v1 recipestest_cross_compileinto files (but without actually updating the migrator, after seeing how much code I'd need to update)DuplicateLinesCleanupmigrator as incompatible with v1 recipes (duplicate keys are an error there)Checklist:
Cross-refs, links to issues, etc: