Some more progress towards recipe v1 minimigrators

conda_forge_tick/migrators/cos7.py

@@ -58,7 +58,12 @@
 
 
 class Cos7Config(MiniMigrator):
+    allowed_schema_versions = {0, 1}
+
     def filter(self, attrs: "AttrsTypedDict", not_bad_str_start: str = "") -> bool:
+        if super().filter(attrs):
+            return True
+
         if any(
             SYSROOT_REGEX.search(line) for line in attrs["raw_meta_yaml"].splitlines()
         ):

conda_forge_tick/migrators/duplicate_lines.py

@@ -10,12 +10,16 @@
 
 
 class DuplicateLinesCleanup(MiniMigrator):
+    # duplicate keys are an error in v1 recipes
+    allowed_schema_versions = {0}
     regex_to_check = {
         "noarch: generic": re.compile(r"^\s*noarch:\s*generic\s*$"),
         "noarch: python": re.compile(r"^\s*noarch:\s*python\s*$"),
     }
 
     def filter(self, attrs: "AttrsTypedDict", not_bad_str_start: str = "") -> bool:
+        if super().filter(attrs):
+            return True
         # we are not handling outputs here since they can make things confusing
         if "outputs" in attrs.get("meta_yaml", ""):
             return True

tests/test_cos7_config_migrator.py

@@ -11,17 +11,25 @@
     piggy_back_migrations=[Cos7Config()],
 )
 
-YAML_PATH = os.path.join(os.path.dirname(__file__), "test_yaml")
+YAML_PATHS = [
+    os.path.join(os.path.dirname(__file__), "test_yaml"),
+    os.path.join(os.path.dirname(__file__), "test_v1_yaml"),
+]
 
 
 @pytest.mark.parametrize("remove_quay", [False, True])
 @pytest.mark.parametrize("case", list(range(len(REQUIRED_RE_LINES))))
-def test_version_cos7_config(case, remove_quay, tmp_path):
-    with open(os.path.join(YAML_PATH, "version_cos7_config_simple.yaml")) as fp:
+@pytest.mark.parametrize("recipe_version", [0, 1])
+def test_version_cos7_config(case, remove_quay, recipe_version, tmp_path):
+    with open(
+        os.path.join(YAML_PATHS[recipe_version], "version_cos7_config_simple.yaml")
+    ) as fp:
         in_yaml = fp.read()
 
     with open(
-        os.path.join(YAML_PATH, "version_cos7_config_simple_correct.yaml"),
+        os.path.join(
+            YAML_PATHS[recipe_version], "version_cos7_config_simple_correct.yaml"
+        ),
     ) as fp:
         out_yaml = fp.read()
 
@@ -49,6 +57,7 @@ def test_version_cos7_config(case, remove_quay, tmp_path):
             "version": "0.9",
         },
         tmp_path=tmp_path,
+        recipe_version=recipe_version,
     )
     with open(cfg) as fp:
         cfg_lines = fp.readlines()
@@ -58,12 +67,17 @@ def test_version_cos7_config(case, remove_quay, tmp_path):
 
 
 @pytest.mark.parametrize("case", list(range(len(REQUIRED_RE_LINES))))
-def test_version_cos7_config_skip(case, tmp_path):
-    with open(os.path.join(YAML_PATH, "version_cos7_config_simple.yaml")) as fp:
+@pytest.mark.parametrize("recipe_version", [0, 1])
+def test_version_cos7_config_skip(case, recipe_version, tmp_path):
+    with open(
+        os.path.join(YAML_PATHS[recipe_version], "version_cos7_config_simple.yaml")
+    ) as fp:
         in_yaml = fp.read()
 
     with open(
-        os.path.join(YAML_PATH, "version_cos7_config_simple_correct.yaml"),
+        os.path.join(
+            YAML_PATHS[recipe_version], "version_cos7_config_simple_correct.yaml"
+        ),
     ) as fp:
         out_yaml = fp.read()
 
@@ -88,6 +102,7 @@ def test_version_cos7_config_skip(case, tmp_path):
             "version": "0.9",
         },
         tmp_path=tmp_path,
+        recipe_version=recipe_version,
     )
     with open(cfg) as fp:
         cfg_lines = fp.readlines()