chore(deps): bump eslint-plugin-jest from 24.4.0 to 26.1.1#1281
chore(deps): bump eslint-plugin-jest from 24.4.0 to 26.1.1#1281mjroeleveld merged 3 commits intomasterfrom
Conversation
db02744 to
2df59e1
Compare
| @@ -1,3 +1,3 @@ | |||
| it('my second test', (): void => { | |||
| expect(1).toStrictEqual('foo'); | |||
| expect(1).toBe('foo'); | |||
There was a problem hiding this comment.
prefer-to-be is a new rule in the recommended set from v25.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2500-2021-10-10
| 'jest/no-conditional-expect': 'off', | ||
| 'jest/require-top-level-describe': 'off', | ||
| 'jest/prefer-called-with': 'off', | ||
| 'jest/prefer-inline-snapshots': 'off', |
There was a problem hiding this comment.
this got deprecated in 25.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2500-2021-10-10, jest-community/eslint-plugin-jest#661, so I believe we can remove it from overrides
| - files: | ||
| - test/fixtures/** | ||
| rules: | ||
| jest/require-hook: off |
There was a problem hiding this comment.
if this is not disabled for the fixture files, they all generate a message about this rule, like the fixture has to be in a hook, which is not true, so to me it looks like it should be disabled for these files. not sure though if additional configuration for this rule is needed for it to work correctly in other repos
|
@dependabot rebase |
|
Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry! If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request |
|
@dependabot recreate |
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.4.0 to 26.1.1. - [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases) - [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md) - [Commits](jest-community/eslint-plugin-jest@v24.4.0...v26.1.1) --- updated-dependencies: - dependency-name: eslint-plugin-jest dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
08d9a0a to
005b38f
Compare
|
@mjroeleveld sorry for re-creating, thought since there are very few changes it would be easier to resolve a package-lock conflict this way |
|
@aaneitchik merged! |
Bumps eslint-plugin-jest from 24.4.0 to 26.1.1.
Release notes
Sourced from eslint-plugin-jest's releases.
... (truncated)
Changelog
Sourced from eslint-plugin-jest's changelog.
... (truncated)
Commits
c55c870chore(release): 26.1.1 [skip ci]7435556fix(docs): use the correct function name (#1056)775f184chore(deps): lock file maintenance7cba106chore(deps): lock file maintenance7f15d9cchore(deps): lock file maintenance7d5b300chore(release): 26.1.0 [skip ci]d854723feat: createprefer-snapshot-hintrule (#1012)ac15932chore(release): 26.1.0-next.2 [skip ci]35f32ccfeat: deprecateno-ifin favor ofno-conditional-in-test(#1049)d56cb0achore(release): 26.1.0-next.1 [skip ci]Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)