-
Notifications
You must be signed in to change notification settings - Fork 1
chore(deps): bump eslint-plugin-jest from 24.4.0 to 26.1.1 #1281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,6 @@ module.exports = { | |
| 'jest/no-conditional-expect': 'off', | ||
| 'jest/require-top-level-describe': 'off', | ||
| 'jest/prefer-called-with': 'off', | ||
| 'jest/prefer-inline-snapshots': 'off', | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this got deprecated in 25.0.0: https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md#2500-2021-10-10, jest-community/eslint-plugin-jest#661, so I believe we can remove it from overrides |
||
| 'jest/prefer-expect-assertions': 'error', | ||
| 'jest/unbound-method': ['error', { ignoreStatic: true }], | ||
| 'jest/valid-title': ['error', { disallowedWords: ['should'] }], | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,3 @@ | ||
| it('my second test', (): void => { | ||
| expect(1).toStrictEqual('foo'); | ||
| expect(1).toBe('foo'); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| }); | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| it('my test', (): void => { | ||
| expect.assertions(1); | ||
| expect(1).toStrictEqual('foo'); | ||
| expect(1).toBe('foo'); | ||
| }); | ||
|
|
||
| it('my test 2', (): void => { | ||
| expect.hasAssertions(); | ||
| expect(1).toStrictEqual('foo'); | ||
| expect(1).toBe('foo'); | ||
| }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if this is not disabled for the fixture files, they all generate a message about this rule, like the fixture has to be in a hook, which is not true, so to me it looks like it should be disabled for these files. not sure though if additional configuration for this rule is needed for it to work correctly in other repos