Conversation
robinweser
approved these changes
Jan 24, 2019
Owner
robinweser
left a comment
There was a problem hiding this comment.
LGTM! Feel free to merge and release. All you need to do is npm run release and select "patch" and it will update all packages and push them.
Collaborator
Author
|
Can't release because flow errors out on unrelated issues (all of them in |
Owner
|
Hmmmm, experienced the same issue with Flow in another repo and I couldn't even ignore them. Feel free to disable flow for the release. Oh, and adding a quick note to the Changelog would be cool. Feel free to also merge #660 and add that one :) |
Collaborator
Author
|
updated the changelog, but I can't merge it without you approving it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #657 where
fela-plugin-extendwould throw when theextendkey in a style object was an array with anullorundefineditem inside it.Adds a test
Packages
fela-plugin-extend
Versioning
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.