Skip to content

fix(fela-plugin-extend): don't throw on undefined items in extend array#658

Merged
TxHawks merged 1 commit intomasterfrom
fix/fela-plugin-extend/throw-on-undefined
Jan 24, 2019
Merged

fix(fela-plugin-extend): don't throw on undefined items in extend array#658
TxHawks merged 1 commit intomasterfrom
fix/fela-plugin-extend/throw-on-undefined

Conversation

@TxHawks
Copy link
Copy Markdown
Collaborator

@TxHawks TxHawks commented Jan 20, 2019

Description

Fixes #657 where fela-plugin-extend would throw when the extend key in a style object was an array with a null or undefined item inside it.

Adds a test

Packages

fela-plugin-extend

Versioning

  • Major
  • Minor
  • Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

Copy link
Copy Markdown
Owner

@robinweser robinweser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Feel free to merge and release. All you need to do is npm run release and select "patch" and it will update all packages and push them.

Comment thread packages/fela-plugin-extend/src/index.js
@TxHawks TxHawks merged commit e6fcdea into master Jan 24, 2019
@TxHawks TxHawks deleted the fix/fela-plugin-extend/throw-on-undefined branch January 24, 2019 10:52
@TxHawks
Copy link
Copy Markdown
Collaborator Author

TxHawks commented Jan 24, 2019

Can't release because flow errors out on unrelated issues (all of them in _book)

@robinweser
Copy link
Copy Markdown
Owner

robinweser commented Jan 24, 2019

Hmmmm, experienced the same issue with Flow in another repo and I couldn't even ignore them. Feel free to disable flow for the release.

Oh, and adding a quick note to the Changelog would be cool. Feel free to also merge #660 and add that one :)

@TxHawks
Copy link
Copy Markdown
Collaborator Author

TxHawks commented Jan 24, 2019

updated the changelog, but I can't merge it without you approving it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants