Skip to content

Fix styling non-standard pseudo elements#660

Merged
TxHawks merged 3 commits intorobinweser:masterfrom
MattCrouch:bug/pseudo-el
Jan 24, 2019
Merged

Fix styling non-standard pseudo elements#660
TxHawks merged 3 commits intorobinweser:masterfrom
MattCrouch:bug/pseudo-el

Conversation

@MattCrouch
Copy link
Copy Markdown
Contributor

Description

This PR fixes an issue with styling pseudo-elements the browser does not understand. This includes vendor-specific elements such as ::-moz-progress-bar.

The cached scoreIndex value would be increased but insertRule method would not add the rule. Any further rules would then result in an IndexSizeError.

Packages

  • fela-dom

Versioning

  • Major
  • Minor
  • Patch

Checklist

Quality Assurance

You can also run yarn run check to run all 4 commands at once.

  • The code was formatted using Prettier (yarn run format)
  • The code has no linting errors (yarn run lint)
  • All tests are passing (yarn run test)
  • There are no flow-type errors (yarn run flow)

Changes

If one of the following checks doesn't make sense due to the type of PR, just check them.

  • Tests have been added/updated
  • Documentation has been added/updated
  • My changes have proper flow-types

Copy link
Copy Markdown
Owner

@robinweser robinweser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TxHawks TxHawks merged commit d43ac77 into robinweser:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants