Fix FelaRenderer TS type extending React.ComponentType#692
Merged
robinweser merged 1 commit intorobinweser:masterfrom Apr 4, 2019
UberMouse:patch-3
Merged
Fix FelaRenderer TS type extending React.ComponentType#692robinweser merged 1 commit intorobinweser:masterfrom UberMouse:patch-3
robinweser merged 1 commit intorobinweser:masterfrom
UberMouse:patch-3
Conversation
ComponentType is a type and interfaces can't extend types, I assume this is supposed to be Component as that is what React classes extend.
Owner
|
Seems reasonable to me, although I don't know much about TypeScript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ComponentType is a type and interfaces can't extend types, I assume this is supposed to be Component as that is what React classes extend. This causes a build failure for me.
Packages
List all packages that have been changed.
Versioning
Patch
Checklist
Quality Assurance
yarn run format)yarn run lint)yarn run test)yarn run flow)Changes
If one of the following checks doesn't make sense due to the type of PR, just check them.
This change is