pcl_ros: enable QoS overrides for lazy input and ouput#519
Open
Spike-hd wants to merge 2 commits intoros-perception:jazzyfrom
Open
pcl_ros: enable QoS overrides for lazy input and ouput#519Spike-hd wants to merge 2 commits intoros-perception:jazzyfrom
Spike-hd wants to merge 2 commits intoros-perception:jazzyfrom
Conversation
Member
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
Please lint, but otherwise LGTM. Are there other places we should add too?
SteveMacenski
approved these changes
Feb 11, 2026
Member
|
@Spike-hd please open for Rolling and I can merge for both rolling and jazzy (so once you move to Lyrical, it'll be ready for you there too) |
Contributor
Author
|
Hi, thanks for reviewing the previous PR. As requested, I’ve now created a version of this patch targeting Rolling (ros2 branch): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the input subscription uses a fixed QoS profile (SensorDataQoS) and does not support ROS 2 QoS parameter overrides. This prevents users from customizing QoS for compatibility with upstream publishers and subscribers.