Skip to content

Switch to target_link_libraries.#776

Merged
clalancette merged 1 commit intorollingfrom
clalancette/target-link-libraries
Nov 27, 2023
Merged

Switch to target_link_libraries.#776
clalancette merged 1 commit intorollingfrom
clalancette/target-link-libraries

Conversation

@clalancette
Copy link
Copy Markdown
Contributor

There really isn't any need to use ament_target_dependencies.

There really isn't any need to use ament_target_dependencies.

Signed-off-by: Chris Lalancette <clalancette@gmail.com>
@clalancette
Copy link
Copy Markdown
Contributor Author

clalancette commented Nov 22, 2023

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Copy Markdown
Member

@wjwwood wjwwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm other than a question

Comment thread rosidl_typesupport_introspection_cpp/CMakeLists.txt
@clalancette clalancette merged commit 5d8191e into rolling Nov 27, 2023
@delete-merged-branch delete-merged-branch Bot deleted the clalancette/target-link-libraries branch November 27, 2023 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants