Make codegen of rosidl_generator_c deterministic for jazzy#957
Open
marlamb wants to merge 1 commit intoros2:jazzyfrom
Open
Make codegen of rosidl_generator_c deterministic for jazzy#957marlamb wants to merge 1 commit intoros2:jazzyfrom
marlamb wants to merge 1 commit intoros2:jazzyfrom
Conversation
Applying the patch merged in ros2#846 to `rolling` branch also to `jazzy` to keep the implementations as close as possible. Signed-off-by: Martin Lambertsen <github@lambertsen.one>
fujitatomoya
approved these changes
Apr 13, 2026
Contributor
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
i think that that is okay to backport this fix to jazzy, i would like to have another review before merge.
Contributor
|
actually maybe if we do this, creating backports PR by mergifyio from #846 to kilted and jazzy would be better to track the history. |
Author
In case you decide so, feel free to close this PR. I don't mind, as long as the functionality becomes available 😃 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying the patch merged in #846 to
rollingbranch also tojazzytokeep the implementations as close as possible.