docs: fix NatSpec in simulateAndRevert#936
Merged
mmv08 merged 1 commit intosafe-fndn:mainfrom Apr 10, 2025
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
mmv08
approved these changes
Apr 4, 2025
nlordell
approved these changes
Apr 4, 2025
Collaborator
|
Hmm, looks like some zkSync tests are failing unrelated to your PR. |
Collaborator
|
@PaulRBerg - can you rebase your PR? @mmv08 fixed the zkSync tests on |
PaulRBerg
force-pushed
the
docs/simulate-and-revert
branch
from
c8c7c02 to
94d5a82
Compare
Contributor
Author
|
Done @nlordell |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the NatSpec documentation in
simulateAndRevertsuch that it no longer incorrectly claims that the return data is ABI encoded(bool, bytes), but instead a custom packed encoding.