Skip to content

docs: fix NatSpec in simulateAndRevert #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmv08 merged 1 commit into from
Apr 10, 2025
Merged

docs: fix NatSpec in simulateAndRevert #936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions contracts/common/StorageAccessible.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ abstract contract StorageAccessible {

/**
* @dev Performs a delegatecall on a targetContract in the context of self.
* Internally reverts execution to avoid side effects (making it static).
* Internally reverts execution to avoid side effects (making it effectively static).
*
* This method reverts with data equal to `abi.encode(bool(success), bytes(response))`.
* This method reverts with data equal to `abi.encodePacked(uint256(success), uint256(response.length), bytes(response))`.
* Specifically, the `returndata` after a call to this method will be:
* `success:bool || response.length:uint256 || response:bytes`.
* `success:uint256 || response.length:uint256 || response:bytes`.
*
* @param targetContract Address of the contract containing the code to execute.
* @param calldataPayload Calldata that should be sent to the target contract (encoded method name and arguments).
Expand Down
Loading
⚡