Crashes due to deleting a mixed selection

[tnspacetime]

Describe the bug
When the input text is selected and the text includes both normal text and a formatted element (bold, italic etc.), then deleting the text causes a crash.

To Reproduce
Steps to reproduce the behavior:

1. Open markdown input to write text
2. Select text, make sure the selection includes both normal text and formatted element (but not the whole input text)
3. Press the delete key
4. See error (crashing)

If the option "Cut" is used, btw, there's no crash, but the markdown format is deformed and parsed incorrectly.

Expected behavior
Deleting mixed selection or cutting should neither crash the app or deform markdown format.

Screenshots
N/A

Device (please complete the following information):

• Device: [e.g. iPhone12]
• Version [e.g. 0.5.0]

[hryhoriiK97]

Hi @tnspacetime, I can’t reproduce this issue. Could you attach a screen recording?

[tnspacetime]

Hi @hryhoriiK97, the issue is sometime it works, sometime it doesn't (for draft input). Just write different mixtures of bold, normal text, italic, then partially select a mixture (not the entire input), and you'll see the crash. Maybe to make it easier to reproduce, make sure the ending text is always normal text. This is an example that sees problem when I select from the end (hello) up to the bold "you" or a bit further and hit delete.

Let me know if you can reproduce it. Btw, I also see buggy deleting behaviour (like partial delete instead of complete delete of a selection).

[hryhoriiK97]

@tnspacetime does this issue appear only on real devices or the simulator? Or on both?

[tnspacetime]

@hryhoriiK97 It's on both. I've tested on both simulator and real device and it crashed on both.

[GeekJC]

@hryhoriiK97 @tnspacetime I am experiencing the similiar issue. when used a Chinese input keyboard, selecting a character will remove the text and cause index of out bound in editLocation, crashing ENRMWordsUtils.

This is the summary provided by AI.
The crash is in react-native-enriched-markdown's native iOS code. The error occurs when range.location (edit location) exceeds the text length after deletion, creating an out-of-bounds range {0, 2} on a string of length 1.
Root Cause: In ENRMWordsUtils.mm:getAffectedWordsFromText:modificationRange:], left = range.location is not bounded to textLength. When a user deletes text, editLocation (from preEditSelection.location) can be beyond the new text length, causing the crash at line 30 when NSMakeRange(0, left) exceeds string bounds.

I will create a seperate issue related to this.

[hryhoriiK97]

@tnspacetime, the fix we applied for #276 should also resolve your issue.

@tnspacetime @GeekJC regarding the markdown deformation issue with the cut option, I’ve created a PR - it will be available in tomorrow’s nightly release.

[tnspacetime]

Thank you 🚀 !