fix(ios): use controlled path for Cut to prevent formatting corruption#278
Merged
hryhoriiK97 merged 3 commits intomainfrom Apr 29, 2026
Merged
fix(ios): use controlled path for Cut to prevent formatting corruption#278hryhoriiK97 merged 3 commits intomainfrom
hryhoriiK97 merged 3 commits intomainfrom
Conversation
Always update _lastSelectedRange in textViewDidChangeSelection and textInputDidChangeSelection before the isApplyingFormatting guard, ensuring _preEditSelectedRange is never stale when handleTextChanged computes edit parameters. Also clamp modificationRange passed to the detector pipeline so out-of-bounds values cannot reach ENRMWordsUtils. Made-with: Cursor
Route Cut through replaceSelectedTextWith:formattingRanges: instead of UIKit's replaceRange:withText: (iOS) / insertText:replacementRange: (macOS). The controlled path bypasses the delegate chain and calls adjustForEditAtLocation: with exact parameters, eliminating timing races that corrupt the formatting store on slower devices or low power mode. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Fixes: #273
Using "Cut" on a mixed selection produces deformed markdown. Cut was routing through UIKit's standard delegate chain (replaceRange:withText:), which is subject to the same timing races. On slower devices or in low power mode, the formatting store gets misaligned because the delegate-based edit parameter inference uses stale values.
Testing
PR Checklist