Skip to content

fix(ios): use controlled path for Cut to prevent formatting corruption #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hryhoriiK97 merged 3 commits into from
Apr 29, 2026
Merged

fix(ios): use controlled path for Cut to prevent formatting corruption #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d740d5c
fix(ios): prevent crash when deleting mixed selection or using IME input
hryhoriiK97 Apr 29, 2026
66bd818
fix(ios): use controlled path for Cut to prevent formatting corruption
hryhoriiK97 Apr 29, 2026
66e0ead
Merge remote-tracking branch 'origin' into fix/ios-cut-formatting-cor…
hryhoriiK97 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ios/input/ENRMInputTextView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ - (void)copy:(id)sender
- (void)cut:(id)sender
{
[self copy:sender];
[self replaceRange:self.selectedTextRange withText:@""];
[self.markdownTextInput replaceSelectedTextWith:@"" formattingRanges:@[]];
}

- (void)paste:(id)sender
Expand Down Expand Up @@ -111,9 +111,7 @@ - (void)copy:(id)sender
- (void)cut:(id)sender
{
[self copy:sender];
if (self.selectedRange.length > 0) {
[self insertText:@"" replacementRange:self.selectedRange];
}
[self.markdownTextInput replaceSelectedTextWith:@"" formattingRanges:@[]];
}

- (void)paste:(id)sender
Expand Down
1 change: 1 addition & 0 deletions ios/input/EnrichedMarkdownTextInput.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ NS_ASSUME_NONNULL_BEGIN
- (CGSize)measureSize:(CGFloat)maxWidth;
- (nullable NSString *)markdownForSelectedRange;
- (void)pasteMarkdown:(NSString *)markdown;
- (void)replaceSelectedTextWith:(NSString *)text formattingRanges:(NSArray *)ranges;
- (void)scheduleRelayoutIfNeeded;
@end

Expand Down
1 change: 0 additions & 1 deletion ios/input/EnrichedMarkdownTextInput.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ - (void)setupTextView;
- (void)applyFormatting;
- (void)toggleInlineStyle:(ENRMInputStyleType)styleType;
- (void)resetBaseTypingAttributes;
- (void)replaceSelectedTextWith:(NSString *)text formattingRanges:(NSArray<ENRMFormattingRange *> *)ranges;
@end

@implementation EnrichedMarkdownTextInput {
Expand Down
Loading
⚡