fix(android): correct insertion boundary in FormattingStore and add serializer bounds check#279
Merged
hryhoriiK97 merged 1 commit intomainfrom Apr 29, 2026
Conversation
…erializer bounds check Change adjustForEdit to shift ranges when editLocation == range.start (using >= instead of >), matching iOS behavior. Without this, typing at the start of a formatted range fails to shift it, causing the inserted character to incorrectly inherit the style. Add bounds clamping in MarkdownSerializer to prevent StringIndexOutOfBoundsException if the formatting store ever contains ranges that exceed the text length. Made-with: Cursor
hryhoriiK97
changed the title
hryhoriiK97
deleted the
fix/android-formatting-store-boundary-and-serializer-bounds
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Change adjustForEdit to shift ranges when editLocation == range.start (using >= instead of >), matching iOS behavior. Without this, typing at the start of a formatted range fails to shift it, causing the inserted character to incorrectly inherit the style.
Add bounds clamping in MarkdownSerializer to prevent StringIndexOutOfBoundsException if the formatting store ever contains ranges that exceed the text length.
Testing
PR Checklist