Skip to content

fix(android): correct insertion boundary in FormattingStore and add serializer bounds check #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hryhoriiK97 merged 1 commit into from
Apr 29, 2026
Merged

fix(android): correct insertion boundary in FormattingStore and add serializer bounds check #279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/src/main/java/com/swmansion/enriched/markdown/input/formatting/FormattingStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ class FormattingStore {
}
} else {
when {
range.start > editLocation -> {
range.start >= editLocation -> {
range.start += insertedLength
range.end += insertedLength
}
Expand Down
6 changes: 4 additions & 2 deletions android/src/main/java/com/swmansion/enriched/markdown/input/formatting/MarkdownSerializer.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ object MarkdownSerializer {

val events = ArrayList<BoundaryEvent>(ranges.size * 2)
for (range in ranges) {
var start = range.start
var end = range.end
var start = range.start.coerceIn(0, text.length)
var end = range.end.coerceIn(0, text.length)

if (start >= end) continue

// Trim leading/trailing whitespace so delimiters hug non-whitespace content
while (start < end && text[start].isWhitespace()) start++
Expand Down
Loading
⚡