bench: refactor random number generation in stats/base/dists/beta#4837
Merged
kgryte merged 1 commit intostdlib-js:developfrom Jan 21, 2025
Merged
bench: refactor random number generation in stats/base/dists/beta#4837kgryte merged 1 commit intostdlib-js:developfrom
stats/base/dists/beta#4837kgryte merged 1 commit intostdlib-js:developfrom
Conversation
…nd use uniform instead of randu
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: na
- task: lint_javascript_benchmarks
status: na
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: na
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
- task: run_javascript_examples
status: na
- task: run_c_examples
status: na
- task: run_cpp_examples
status: na
- task: run_javascript_readme_examples
status: na
- task: run_c_benchmarks
status: na
- task: run_cpp_benchmarks
status: na
- task: run_fortran_benchmarks
status: na
- task: run_javascript_benchmarks
status: na
- task: run_julia_benchmarks
status: na
- task: run_python_benchmarks
status: na
- task: run_r_benchmarks
status: na
- task: run_javascript_tests
status: na
---
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jan 21, 2025
Member
kgryte
left a comment
There was a problem hiding this comment.
LGTM. Thanks for working on this, @anandkaranubc!
This was referenced Jan 31, 2025
Open
Closed
Closed
Closed
Open
Vinit-Pandit
pushed a commit
to Vinit-Pandit/stdlibMine
that referenced
this pull request
Feb 4, 2025
PR-URL: stdlib-js#4837 Reviewed-by: Athan Reines <kgryte@gmail.com>
1 task
Planeshifter
added a commit
that referenced
this pull request
Feb 12, 2025
…e/dists/uniform` PR-URL: #5176 Closes: #4991 Ref: #4837 Ref: #4955 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
This was referenced Feb 13, 2025
Planeshifter
pushed a commit
that referenced
this pull request
Feb 17, 2025
…ized-range` PR-URL: #5175 Closes: #4987 Ref: #4955 Ref: #4837 Co-authored-by: Karan Anand <anandkaranubc@users.noreply.github.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Karan Anand <anandkaranubc@users.noreply.github.com> Signed-off-by: Harsh <149176984+hrshya@users.noreply.github.com>
0PrashantYadav0
pushed a commit
to 0PrashantYadav0/stdlib
that referenced
this pull request
Feb 19, 2025
PR-URL: stdlib-js#4837 Reviewed-by: Athan Reines <kgryte@gmail.com>
This was referenced Feb 20, 2025
ShabiShett07
pushed a commit
to ShabiShett07/stdlib
that referenced
this pull request
Feb 26, 2025
PR-URL: stdlib-js#4837 Reviewed-by: Athan Reines <kgryte@gmail.com>
ShabiShett07
pushed a commit
to ShabiShett07/stdlib
that referenced
this pull request
Feb 26, 2025
…e/dists/uniform` PR-URL: stdlib-js#5176 Closes: stdlib-js#4991 Ref: stdlib-js#4837 Ref: stdlib-js#4955 Co-authored-by: Philipp Burckhardt <pburckhardt@outlook.com> Co-authored-by: stdlib-bot <noreply@stdlib.io> Reviewed-by: Karan Anand <119553199+anandkaranubc@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com> Signed-off-by: Philipp Burckhardt <pburckhardt@outlook.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves none.
Description
This pull request:
stats/base/dists/beta.randu()withuniform()for cleaner and more consistent code.Related Issues
This pull request:
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers