bench: refactor random number generation in stats/base/dists/signrank#9594
Closed
AryanJ18 wants to merge 6 commits intostdlib-js:developfrom
Closed
bench: refactor random number generation in stats/base/dists/signrank#9594AryanJ18 wants to merge 6 commits intostdlib-js:developfrom
AryanJ18 wants to merge 6 commits intostdlib-js:developfrom
Conversation
bench:refactor random number generation in stats/base/dists/signrank issue: stdlib-js#4986
stdlib-bot
added
Good First PR
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
bench: refactor random number generation in stats/base/dists/signrank issue: stdlib-js#4986
AryanJ18
changed the title
Contributor
Author
|
@anandkaranubc please review the following pr |
Comment on lines
+24
to
+26
| var Float64Array = require( '@stdlib/array/float64' ); | ||
| var uniform = require( '@stdlib/random/base/uniform' ); | ||
| var discreteUniform = require( '@stdlib/random/base/discrete-uniform' ); |
Contributor
There was a problem hiding this comment.
Can you refactor this to use @stdlib/random/array/uniform and @stdlib/random/array/discrete-uniform instead? In that way, you won't need Float64Array. Just as done here in this file.
Contributor
There was a problem hiding this comment.
Same comment applies to the other file.
Contributor
There was a problem hiding this comment.
Can you add the same changes to their respective benchmark.native.js files as well please? Thanks!
anandkaranubc
requested changes
Jan 11, 2026
Contributor
anandkaranubc
left a comment
anandkaranubc
left a comment
There was a problem hiding this comment.
Left a couple of comments. Thanks @AryanJ18 for the PR!
kgryte
added
Needs Changes
Signed-off-by: AryanJ18 <18aryanj2006@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bench:refactor random number generation in stats/base/dists/signrank issue: #4986
Resolves #4986 .
Description
This pull request:
This pull request improves random number generation in JS benchmarks for stats/base/dists/signrank. Specifically:
Moves random number generation out of benchmarking loops to prevent interference with benchmark results.
Uses @stdlib/random/base/uniform and @stdlib/random/base/discrete-uniform instead of randu expressions.
Ensures generated random values maintain the same range as existing values for consistency.
Related Issues
This pull request has the following related issues:
References #4837 and #4955 as examples of similar improvements.
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers