Add state() method handling for components#1028
Merged
Rich-Harris merged 1 commit intosveltejs:masterfrom Dec 16, 2017
emilos:master
Merged
Add state() method handling for components#1028Rich-Harris merged 1 commit intosveltejs:masterfrom emilos:master
Rich-Harris merged 1 commit intosveltejs:masterfrom
emilos:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1028 +/- ##
=========================================
- Coverage 92.01% 92% -0.02%
=========================================
Files 119 119
Lines 4356 4363 +7
Branches 1402 1406 +4
=========================================
+ Hits 4008 4014 +6
Misses 148 148
- Partials 200 201 +1
Continue to review full report at Codecov.
|
Member
|
Awesome, thanks so much! |
Rich-Harris
added a commit
that referenced
this pull request
Dec 16, 2017
get store() to work with nested components in SSR compiler
sacrosanctic
pushed a commit
to sacrosanctic/svelte
that referenced
this pull request
Dec 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
This PR is a proposal of API extension that would allow setting the
Storeinside of the top level component (previously discussed briefly in gitter).The motivation for such change is making it easier to consume the component in other apps.
Instead of:
it would become:
where the
storewould become an implementation detail instead.Please let me know if there's anything missing (e.g. specs of some type) and I'll add :).
Thanks!