Skip to content

dashboard: default close telemetry#5974

Merged
ti-chi-bot merged 6 commits intotikv:masterfrom
nolouch:default-close-telemetry
Feb 13, 2023
Merged

dashboard: default close telemetry#5974
ti-chi-bot merged 6 commits intotikv:masterfrom
nolouch:default-close-telemetry

Conversation

@nolouch
Copy link
Copy Markdown
Contributor

@nolouch nolouch commented Feb 13, 2023

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Close #5973

What is changed and how does it work?

dashboard: default close telemetry

Check List

Tests

  • Unit test
  • Integration test

Release note

default close TiDB dashboard's telemetry

@nolouch
dashboard: default close telemetry
691d03e 
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Feb 13, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

@baurine: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 13, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 13, 2023
@baurine
Copy link
Copy Markdown
Contributor

baurine commented Feb 13, 2023

Please help cherry-pick to 6.1 and 6.5 versions after merging, thanks!

@nolouch
Copy link
Copy Markdown
Contributor Author

nolouch commented Feb 13, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 691d03e

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 13, 2023
@nolouch nolouch added needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. labels Feb 13, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

@nolouch: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1bc8e2a into tikv:master Feb 13, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 13, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

In response to a cherrypick label: new pull request created to branch release-6.1: #5982.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 13, 2023
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#5974
a6ff8ee 
close tikv#5973

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 13, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #5983.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Feb 13, 2023
@nolouch @ti-chi-bot
This is an automated cherry-pick of tikv#5974
9d0ff20 
close tikv#5973

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Feb 13, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Feb 13, 2023

In response to a cherrypick label: new pull request created to branch release-6.6: #5984.

@nolouch nolouch deleted the default-close-telemetry branch February 13, 2023 11:10
ti-chi-bot added a commit that referenced this pull request Feb 14, 2023
@ti-chi-bot @nolouch
dashboard: default close telemetry (#5974) (#5983)
1985ea3 
close #5973, ref #5974

dashboard: default close telemetry

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this pull request Feb 14, 2023
@ti-chi-bot @nolouch
dashboard: default close telemetry (#5974) (#5984)
67c0fa2 
close #5973, ref #5974

dashboard: default close telemetry

Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: nolouch <nolouch@gmail.com>
Co-authored-by: ShuNing <nolouch@gmail.com>
ti-chi-bot added a commit that referenced this pull request Feb 15, 2023
@ti-chi-bot @nolouch
dashboard: default close telemetry (#5974) (#5982)
18a8356 
close #5973, ref #5974

dashboard: default close telemetry

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: nolouch <nolouch@gmail.com>

Co-authored-by: ShuNing <nolouch@gmail.com>
Co-authored-by: nolouch <nolouch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@rleungx rleungx rleungx approved these changes

+1 more reviewer

@baurine baurine baurine approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.6 release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Default close telemetry

6 participants

@nolouch @ti-chi-bot @baurine @disksing @lhy1024 @rleungx
⚡