Skip to content

dashboard: default close telemetry (#5974)#5983

Merged
ti-chi-bot merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-5974-to-release-6.5
Feb 14, 2023
Merged

dashboard: default close telemetry (#5974)#5983
ti-chi-bot merged 3 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-5974-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #5974

Signed-off-by: nolouch nolouch@gmail.com

What problem does this PR solve?

Issue Number: Close #5973

What is changed and how does it work?

dashboard: default close telemetry

Check List

Tests

  • Unit test
  • Integration test

Release note

default close TiDB dashboard's telemetry

close tikv#5973

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Feb 13, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lhy1024
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Feb 13, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 13, 2023

Codecov Report

Base: 75.51% // Head: 75.52% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (9d0ff20) compared to base (b04f0a9).
Patch has no changes to coverable lines.

❗ Current head 9d0ff20 differs from pull request most recent head 9e101ae. Consider uploading reports for the commit 9e101ae to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #5983      +/-   ##
===============================================
+ Coverage        75.51%   75.52%   +0.01%     
===============================================
  Files              330      330              
  Lines            32952    32948       -4     
===============================================
+ Hits             24884    24885       +1     
+ Misses            5911     5910       -1     
+ Partials          2157     2153       -4     
Flag Coverage Δ
unittests 75.52% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/config/config.go 78.90% <ø> (+0.45%) ⬆️
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/storage/hot_region_storage.go 79.23% <0.00%> (-3.83%) ⬇️
server/schedule/labeler/rules.go 87.50% <0.00%> (-2.28%) ⬇️
server/tso/tso.go 67.97% <0.00%> (-2.25%) ⬇️
server/tso/allocator_manager.go 61.29% <0.00%> (-1.46%) ⬇️
server/schedulers/hot_region_v2.go 88.30% <0.00%> (-1.17%) ⬇️
pkg/btree/btree_generic.go 86.34% <0.00%> (-0.93%) ⬇️
server/schedule/operator/step.go 73.09% <0.00%> (-0.72%) ⬇️
server/server.go 74.53% <0.00%> (-0.62%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@lhy1024 lhy1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz fix conflict

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 14, 2023
@VelocityLight VelocityLight added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Feb 14, 2023
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 14, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Feb 14, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Member Author

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 2afef62

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 14, 2023
@ti-chi-bot
Copy link
Copy Markdown
Member Author

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit 1985ea3 into tikv:release-6.5 Feb 14, 2023
@VelocityLight VelocityLight added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. and removed cherry-pick-approved Cherry pick PR approved by release team. do-not-merge/cherry-pick-not-approved labels Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants