checker: fix the too many orphan peers cannot be removed by nolouch · Pull Request #6574 · tikv/pd

nolouch · 2023-06-08T07:58:00Z

What problem does this PR solve?

Issue Number: Close #6573

What is changed and how does it work?

rule-checker: fix the too many orphan peers that cannot be removed
- let the health peer can be removed once there exist redundant

Check List

Tests

Unit test

Release note

Fix the issue too many peers/learners cannot be removed

codecov · 2023-06-08T08:20:53Z

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (026ddf0) 74.61% compared to head (482cd9b) 74.66%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6574      +/-   ##
==========================================
+ Coverage   74.61%   74.66%   +0.04%     
==========================================
  Files         416      416              
  Lines       42576    42581       +5     
==========================================
+ Hits        31769    31794      +25     
+ Misses       7995     7991       -4     
+ Partials     2812     2796      -16

Flag	Coverage Δ
unittests	`74.66% <100.00%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/schedule/checker/rule_checker.go	`83.45% <100.00%> (+1.03%)`	⬆️

... and 29 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: nolouch <nolouch@gmail.com>

CabinfeverB · 2023-06-08T08:35:45Z

pkg/schedule/checker/rule_checker_test.go

+	suite.cluster.AddLeaderStore(4, 1)
+	suite.cluster.AddLeaderStore(5, 1)
+	suite.cluster.AddLeaderStore(6, 1)
+	suite.cluster.AddRegionWithLearner(1, 1, []uint64{2, 3}, []uint64{4, 5, 6})


This comment should have nothing to do with this PR. But I want to know what happen if here is suite.cluster.AddRegionWithLearner(1, 1, []uint64{2, 3}, []uint64{4}), and other behaviors are same.

It seems not return operator

yes, because need len(OrphanPeers) >=2

Signed-off-by: nolouch <nolouch@gmail.com>

CabinfeverB · 2023-06-08T08:50:03Z

Why bot does not add label for this PR..

nolouch · 2023-06-08T10:00:59Z

/merge

ti-chi-bot · 2023-06-08T10:01:01Z

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-08T10:01:02Z

@nolouch: /merge in this pull request requires 2 approval(s).

Details

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

wuhuizuo · 2023-06-08T10:07:57Z

Why bot does not add label for this PR..

Bot offline for serval minutes, please re approve it again with github review approving.

ti-chi-bot · 2023-06-08T10:56:20Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

CabinfeverB · 2023-06-08T10:58:43Z

/merge

ti-chi-bot · 2023-06-08T10:58:45Z

@CabinfeverB: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-08T10:58:47Z

This pull request has been accepted and is ready to merge.

Details

Commit hash: 482cd9b

CabinfeverB · 2023-06-08T11:42:11Z

/test build

ti-chi-bot · 2023-06-08T11:50:04Z

In response to a cherrypick label: new pull request created to branch release-6.5: #6575.

ti-chi-bot · 2023-06-08T11:50:41Z

In response to a cherrypick label: new pull request created to branch release-7.1: #6576.

close #6573, ref #6574 rule-checker: fix the too many orphan peers that cannot be removed - let the health peer can be removed once there exist redundant Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com>

close #6573, ref #6574 rule-checker: fix the too many orphan peers that cannot be removed - let the health peer can be removed once there exist redundant Signed-off-by: nolouch <nolouch@gmail.com> Co-authored-by: nolouch <nolouch@gmail.com> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>

nolouch force-pushed the fix-remove-orphan branch from c531cee to f56ca51 Compare June 8, 2023 08:00

nolouch requested review from CabinfeverB and rleungx June 8, 2023 08:01

nolouch changed the title ~~checker: fix the too many orphan peers cannot be remove~~ checker: fix the too many orphan peers cannot be removed Jun 8, 2023

nolouch force-pushed the fix-remove-orphan branch from f56ca51 to 2db0579 Compare June 8, 2023 08:07

rleungx approved these changes Jun 8, 2023

View reviewed changes

nolouch force-pushed the fix-remove-orphan branch from 2db0579 to 63e6a54 Compare June 8, 2023 08:25

checker: fix the too many orphan peers cannot be removed

0229f17

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch force-pushed the fix-remove-orphan branch from 63e6a54 to 0229f17 Compare June 8, 2023 08:27

CabinfeverB reviewed Jun 8, 2023

View reviewed changes

CabinfeverB approved these changes Jun 8, 2023

View reviewed changes

address comment

482cd9b

Signed-off-by: nolouch <nolouch@gmail.com>

nolouch added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 8, 2023

ti-chi-bot bot removed the status/LGT2 Indicates that a PR has LGTM 2. label Jun 8, 2023

CabinfeverB approved these changes Jun 8, 2023

View reviewed changes

ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 8, 2023

CabinfeverB added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jun 8, 2023

ti-chi-bot bot added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Jun 8, 2023

CabinfeverB added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 8, 2023

ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 8, 2023

ti-chi-bot bot merged commit e807811 into tikv:master Jun 8, 2023

ti-chi-bot mentioned this pull request Jun 8, 2023

checker: fix the too many orphan peers cannot be removed (#6574) #6575

Merged

ti-chi-bot mentioned this pull request Jun 8, 2023

checker: fix the too many orphan peers cannot be removed (#6574) #6576

Merged

nolouch deleted the fix-remove-orphan branch June 8, 2023 11:56

Conversation

nolouch commented Jun 8, 2023 • edited by CabinfeverB Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

codecov bot commented Jun 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

CabinfeverB Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

CabinfeverB Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

nolouch Jun 8, 2023

Choose a reason for hiding this comment

Uh oh!

CabinfeverB commented Jun 8, 2023

Uh oh!

nolouch commented Jun 8, 2023

Uh oh!

ti-chi-bot bot commented Jun 8, 2023

Uh oh!

ti-chi-bot bot commented Jun 8, 2023

Uh oh!

wuhuizuo commented Jun 8, 2023

Uh oh!

ti-chi-bot bot commented Jun 8, 2023

Uh oh!

CabinfeverB commented Jun 8, 2023

Uh oh!

ti-chi-bot bot commented Jun 8, 2023

Uh oh!

ti-chi-bot bot commented Jun 8, 2023

Uh oh!

CabinfeverB commented Jun 8, 2023

Uh oh!

ti-chi-bot commented Jun 8, 2023

Uh oh!

ti-chi-bot commented Jun 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nolouch commented Jun 8, 2023 •

edited by CabinfeverB

Loading

codecov bot commented Jun 8, 2023 •

edited

Loading