Skip to content

checker: fix the too many orphan peers cannot be removed (#6574)#6576

Merged
ti-chi-bot[bot] merged 3 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-6574-to-release-7.1
Jun 26, 2023
Merged

checker: fix the too many orphan peers cannot be removed (#6574)#6576
ti-chi-bot[bot] merged 3 commits intotikv:release-7.1from
ti-chi-bot:cherry-pick-6574-to-release-7.1

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #6574

What problem does this PR solve?

Issue Number: Close #6573

What is changed and how does it work?

rule-checker: fix the too many orphan peers that cannot be removed
- let the health peer can be removed once there exist redundant

Check List

Tests

  • Unit test

Release note

Fix the issue too many peers/learners cannot be removed

nolouch added 2 commits June 8, 2023 11:50
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jun 8, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jun 8, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and nolouch June 8, 2023 11:50
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21 🎉

Comparison is base (0f65c6c) 74.76% compared to head (7bea134) 74.98%.

❗ Current head 7bea134 differs from pull request most recent head e7ee8bf. Consider uploading reports for the commit e7ee8bf to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.1    #6576      +/-   ##
===============================================
+ Coverage        74.76%   74.98%   +0.21%     
===============================================
  Files              408      408              
  Lines            40740    40741       +1     
===============================================
+ Hits             30461    30551      +90     
+ Misses            7593     7532      -61     
+ Partials          2686     2658      -28     
Flag Coverage Δ
unittests 74.98% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/checker/rule_checker.go 83.45% <100.00%> (+1.03%) ⬆️

... and 30 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 14, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 21, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Jun 26, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jun 26, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Jun 26, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: 7bea134

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2949a53 into tikv:release-7.1 Jun 26, 2023
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants