replication_mode: use placement to determin canSync and hasMajority#7202
Conversation
Signed-off-by: disksing <i@disksing.com>
Signed-off-by: disksing <i@disksing.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## master #7202 +/- ##
==========================================
- Coverage 74.58% 74.54% -0.05%
==========================================
Files 442 442
Lines 47681 47744 +63
==========================================
+ Hits 35565 35589 +24
- Misses 8990 9008 +18
- Partials 3126 3147 +21
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/run-check-issue-triage-complete |
|
/merge |
|
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
This pull request has been accepted and is ready to merge. DetailsCommit hash: 474b2aa |
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7201 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
In response to a cherrypick label: failed to apply #7202 on top of branch "release-7.5": |
|
In response to a cherrypick label: new pull request created to branch |
close tikv#7201 Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
What problem does this PR solve?
Issue Number: Close #7201
What is changed and how does it work?
canSyncandhasMajorityflags based on placement rule configuration.Check List
Tests
Code changes
primary-replicasanddr-replicasconfigurations are not deprecated.Related changes
Release note