Skip to content

replication_mode: use placement to determin canSync and hasMajority (#7202)#7209

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-7202-to-release-6.5
Oct 16, 2023
Merged

replication_mode: use placement to determin canSync and hasMajority (#7202)#7209
ti-chi-bot[bot] merged 2 commits intotikv:release-6.5from
ti-chi-bot:cherry-pick-7202-to-release-6.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Oct 16, 2023

This is an automated cherry-pick of #7202

What problem does this PR solve?

Issue Number: Close #7201

What is changed and how does it work?

  • determine canSync and hasMajority flags based on placement rule configuration.

Check List

Tests

  • Unit test

Code changes

  • Has the configuration change
    primary-replicas and dr-replicas configurations are not deprecated.

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@disksing @ti-chi-bot
This is an automated cherry-pick of tikv#7202
344a7a9 
close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Oct 16, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Oct 16, 2023
Merged
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 16, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Details

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx October 16, 2023 06:28
@disksing
fix build
e348f3e 
Signed-off-by: disksing <i@disksing.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Files Coverage Δ
server/replication/replication_mode.go 82.16% <88.00%> (-0.65%) ⬇️

... and 17 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 16, 2023
@disksing disksing requested review from CabinfeverB and nolouch and removed request for rleungx October 16, 2023 07:20
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 16, 2023
@disksing
Copy link
Copy Markdown
Contributor

disksing commented Oct 16, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 16, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 16, 2023

This pull request has been accepted and is ready to merge.

DetailsCommit hash: e348f3e

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 16, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 16, 2023
@nolouch
Copy link
Copy Markdown
Contributor

nolouch commented Oct 16, 2023

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 16, 2023

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit ba09621 into tikv:release-6.5 Oct 16, 2023
disksing added a commit to oh-my-tidb/pd that referenced this pull request Oct 30, 2023
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
60df228 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
disksing added a commit that referenced this pull request Oct 30, 2023
@disksing @ti-chi-bot
replication_mode: use placement to determin canSync and hasMajority (#…
4ba0fa6 
…7202) (#7209) (#7285)

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
disksing added a commit to oh-my-tidb/pd that referenced this pull request Feb 1, 2024
@ti-chi-bot @disksing
replication_mode: use placement to determin canSync and hasMajority (t…
6a00c42 
…ikv#7202) (tikv#7209)

close tikv#7201

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: disksing <i@disksing.com>

Co-authored-by: disksing <i@disksing.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@CabinfeverB CabinfeverB CabinfeverB approved these changes

@nolouch nolouch Awaiting requested review from nolouch

Assignees

@disksing disksing

Labels

cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @disksing @nolouch @CabinfeverB
⚡