Skip to content

chore(deps): bump Go to 1.23.12 and update tidb-dashboard dependency#9787

Merged
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
JmPotato:update_go_version
Sep 29, 2025
Merged

chore(deps): bump Go to 1.23.12 and update tidb-dashboard dependency#9787
ti-chi-bot[bot] merged 1 commit intotikv:masterfrom
JmPotato:update_go_version

Conversation

@JmPotato
Copy link
Copy Markdown
Member

@JmPotato JmPotato commented Sep 29, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #9788.

What is changed and how does it work?

- Upgraded Go version from 1.23.0 → 1.23.12 to adopt security fixes.
- Updated github.com/pingcap/tidb-dashboard to latest commit (https://github.com/pingcap/tidb-dashboard/commit/e111aaee93f465ac07e4e6c9cf79546408b5eec9).

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 29, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.73%. Comparing base (f8ab6e5) to head (e295d51).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9787      +/-   ##
==========================================
- Coverage   76.75%   76.73%   -0.03%     
==========================================
  Files         490      491       +1     
  Lines       78166    78458     +292     
==========================================
+ Hits        59994    60202     +208     
- Misses      14499    14571      +72     
- Partials     3673     3685      +12
Flag Coverage Δ
unittests 76.73% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 29, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-09-29 02:50:46.362037195 +0000 UTC m=+53026.618768605: ☑️ agreed by bufferflies.
  • 2025-09-29 02:57:13.459439332 +0000 UTC m=+53413.716170732: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 50a938a into tikv:master Sep 29, 2025
29 of 30 checks passed
@JmPotato JmPotato deleted the update_go_version branch September 29, 2025 03:20
@JmPotato JmPotato mentioned this pull request Sep 29, 2025
Closed
@JmPotato
Copy link
Copy Markdown
Member Author

JmPotato commented Sep 29, 2025

/cherry-pick release-8.5

@tikv tikv deleted a comment from ti-chi-bot Sep 29, 2025
@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Sep 29, 2025

@JmPotato: new pull request created to branch release-8.5: #9789.
But this PR has conflicts, please resolve them!

Details

In response to this:

/cherry-pick release-8.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2025
Merged
JmPotato added a commit to ti-chi-bot/pd that referenced this pull request Oct 9, 2025
@JmPotato
This is an automated cherry-pick of tikv#9787
19e3e21 
ref tikv#4399

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <github@ipotato.me>
ti-chi-bot bot pushed a commit that referenced this pull request Oct 10, 2025
@ti-chi-bot @JmPotato
chore(deps): bump Go to 1.23.12 and update tidb-dashboard dependency (#…
064b2ad 
…9787) (#9789)

close #9788

- Upgraded Go version from 1.23.0 → 1.23.12 to adopt security fixes.
- Updated github.com/pingcap/tidb-dashboard to latest release-8.5 commit (pingcap/tidb-dashboard@8cfdaf4).

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <github@ipotato.me>

Co-authored-by: JmPotato <ghzpotato@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bufferflies bufferflies bufferflies approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bump Golang version to adopt the security fixes

4 participants

@JmPotato @ti-chi-bot @bufferflies @okJiang
⚡