Skip to content

chore(deps): bump Go to 1.23.12 and update tidb-dashboard dependency (#9787)#9789

Merged
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-9787-to-release-8.5
Oct 10, 2025
Merged

chore(deps): bump Go to 1.23.12 and update tidb-dashboard dependency (#9787)#9789
ti-chi-bot[bot] merged 1 commit intotikv:release-8.5from
ti-chi-bot:cherry-pick-9787-to-release-8.5

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Sep 29, 2025 •
edited by JmPotato
Loading

This is an automated cherry-pick of #9787

What problem does this PR solve?

Issue Number: close #9788.

What is changed and how does it work?

- Upgraded Go version from 1.23.0 → 1.23.12 to adopt security fixes.
- Updated github.com/pingcap/tidb-dashboard to latest release-8.5 commit (https://github.com/pingcap/tidb-dashboard/commit/8cfdaf48f4b1458a13ab12ba302d17f624ce0494).

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 29, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 29, 2025
Merged
@ti-chi-bot
Copy link
Copy Markdown
Member Author

ti-chi-bot commented Sep 29, 2025

@JmPotato This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Sep 29, 2025

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 29, 2025
@JmPotato
This is an automated cherry-pick of tikv#9787
19e3e21 
ref tikv#4399

Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Signed-off-by: JmPotato <github@ipotato.me>
@JmPotato JmPotato force-pushed the cherry-pick-9787-to-release-8.5 branch from eae6342 to 19e3e21 Compare October 9, 2025 07:26
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2025
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 9, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.83%. Comparing base (b448fca) to head (19e3e21).
⚠️ Report is 1 commits behind head on release-8.5.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-8.5    #9789      +/-   ##
===============================================
- Coverage        75.92%   75.83%   -0.09%     
===============================================
  Files              467      467              
  Lines            73919    73919              
===============================================
- Hits             56121    56060      -61     
- Misses           14239    14297      +58     
- Partials          3559     3562       +3
Flag Coverage Δ
unittests 75.83% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-09 07:26:50.358105805 +0000 UTC m=+338799.389205123: ☑️ agreed by JmPotato.
  • 2025-10-09 08:59:48.376122474 +0000 UTC m=+344377.407221802: ☑️ agreed by bufferflies.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bufferflies, JmPotato, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [JmPotato,bufferflies]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Oct 9, 2025
@JmPotato JmPotato removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2025
@ti-chi-bot ti-chi-bot bot merged commit 064b2ad into tikv:release-8.5 Oct 10, 2025
27 of 34 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-9787-to-release-8.5 branch October 10, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@bufferflies bufferflies bufferflies approved these changes

+1 more reviewer

@okJiang okJiang okJiang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JmPotato JmPotato

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ti-chi-bot @JmPotato @bufferflies @okJiang
⚡