Skip to content

core: skip tiflash engine role key check#9849

Merged
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
rleungx:fix-tiflash-label-1
Oct 28, 2025
Merged

core: skip tiflash engine role key check#9849
ti-chi-bot[bot] merged 2 commits intotikv:masterfrom
rleungx:fix-tiflash-label-1

Conversation

@rleungx
Copy link
Copy Markdown
Member

@rleungx rleungx commented Oct 21, 2025

What problem does this PR solve?

Issue Number: Close #9848

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@rleungx
skip engine_role label check
9dd6951 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@rleungx
add test
65a7700 
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 21, 2025
JaySon-Huang
JaySon-Huang approved these changes Oct 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@JaySon-Huang JaySon-Huang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reference on tiflash codebase: https://github.com/pingcap/tiflash/blob/80e1927d83a7cd0b53975c86a6f7ab539fbc8192/dbms/src/Storages/KVStore/ProxyStateMachine.h#L163-L178

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 21, 2025

@JaySon-Huang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rleungx rleungx requested review from JmPotato and lhy1024 October 21, 2025 08:18
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 21, 2025
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 28, 2025

/retest

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.64%. Comparing base (14ac685) to head (65a7700).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9849      +/-   ##
==========================================
+ Coverage   76.87%   78.64%   +1.77%     
==========================================
  Files         491      491              
  Lines       78475    66112   -12363     
==========================================
- Hits        60324    51995    -8329     
+ Misses      14457    10412    -4045     
- Partials     3694     3705      +11
Flag Coverage Δ
unittests 78.64% <100.00%> (+1.77%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JaySon-Huang, JmPotato, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-21 09:55:58.576856671 +0000 UTC m=+779264.654109230: ☑️ agreed by JmPotato.
  • 2025-10-28 02:50:39.937707277 +0000 UTC m=+1358546.014959827: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot bot merged commit 15e74e4 into tikv:master Oct 28, 2025
38 of 41 checks passed
@rleungx rleungx deleted the fix-tiflash-label-1 branch October 28, 2025 03:49
@rleungx
Copy link
Copy Markdown
Member Author

rleungx commented Oct 28, 2025

/cherry-pick release-nextgen-20251011

@ti-chi-bot
Copy link
Copy Markdown
Member

ti-chi-bot commented Oct 28, 2025

@rleungx: new pull request created to branch release-nextgen-20251011: #9877.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Oct 28, 2025
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Oct 28, 2025
@ti-chi-bot @rleungx
core: skip tiflash engine role key check (#9849) (#9877)
354ad77 
close #9848

Signed-off-by: Ryan Leung <rleungx@gmail.com>

Co-authored-by: Ryan Leung <rleungx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JmPotato JmPotato JmPotato approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

+1 more reviewer

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[next-gen on clould] pd print abnormal log "not found the key match with the store label"

5 participants

@rleungx @ti-chi-bot @JmPotato @JaySon-Huang @lhy1024
⚡