Skip to content

core: skip tiflash engine role key check (#9849)#9877

Merged
ti-chi-bot[bot] merged 2 commits intotikv:release-nextgen-20251011from
ti-chi-bot:cherry-pick-9849-to-release-nextgen-20251011
Oct 28, 2025
Merged

core: skip tiflash engine role key check (#9849)#9877
ti-chi-bot[bot] merged 2 commits intotikv:release-nextgen-20251011from
ti-chi-bot:cherry-pick-9849-to-release-nextgen-20251011

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #9849

What problem does this PR solve?

Issue Number: Close #9848

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <rleungx@gmail.com>
Signed-off-by: Ryan Leung <rleungx@gmail.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Oct 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.70%. Comparing base (5bbec7c) to head (429ed63).
⚠️ Report is 4 commits behind head on release-nextgen-20251011.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           release-nextgen-20251011    #9877      +/-   ##
============================================================
- Coverage                     78.73%   78.70%   -0.04%     
============================================================
  Files                           491      491              
  Lines                         65896    66094     +198     
============================================================
+ Hits                          51880    52016     +136     
- Misses                        10340    10390      +50     
- Partials                       3676     3688      +12     
Flag Coverage Δ
unittests 78.70% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 28, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Oct 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-28 06:36:32.250273537 +0000 UTC m=+1372098.327526096: ☑️ agreed by lhy1024.
  • 2025-10-28 06:41:54.334496625 +0000 UTC m=+1372420.411749185: ☑️ agreed by rleungx.

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Oct 28, 2025

/override pull-unit-test-next-gen

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

@rleungx: Overrode contexts on behalf of rleungx: pull-unit-test-next-gen

Details

In response to this:

/override pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 354ad77 into tikv:release-nextgen-20251011 Oct 28, 2025
33 of 35 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-9849-to-release-nextgen-20251011 branch October 28, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants