gc: Add keyspace name to logs about GC by MyonKeminta · Pull Request #9875 · tikv/pd

MyonKeminta · 2025-10-27T09:19:53Z

What problem does this PR solve?

Issue Number: Close #8978

What is changed and how does it work?

As keyspace ID is hidden in metrics and hidden to users, printing keyspace ID in logs might not help in diagnosing. This PR adds keyspace name field to the logs of the GC state manager, while still keeping the keyspace ID in the logs.

Check List

Tests

Unit test
Manual test (add detailed scripts or steps below)

Code changes

-

Side effects

Increased code complexity

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tiup:
Need to cherry-pick to the release branch

Release note

None.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

ti-chi-bot · 2025-10-27T09:45:58Z

[LGTM Timeline notifier]

Timeline:

2025-10-27 09:36:46.473732731 +0000 UTC m=+1296512.550985281: ☑️ agreed by rleungx.
2025-10-27 09:45:57.785157063 +0000 UTC m=+1297063.862409613: ☑️ agreed by okJiang.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

MyonKeminta · 2025-10-27T09:57:04Z

/retest

MyonKeminta · 2025-10-27T10:01:55Z

/retest

MyonKeminta · 2025-10-27T10:13:55Z

/retest

codecov · 2025-10-27T10:22:42Z

Codecov Report

❌ Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.62%. Comparing base (14ac685) to head (0c4a973).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #9875      +/-   ##
==========================================
+ Coverage   76.87%   78.62%   +1.75%     
==========================================
  Files         491      491              
  Lines       78475    66238   -12237     
==========================================
- Hits        60324    52082    -8242     
+ Misses      14457    10436    -4021     
- Partials     3694     3720      +26

Flag	Coverage Δ
unittests	`78.62% <86.66%> (+1.75%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

MyonKeminta · 2025-10-27T11:32:38Z

/test pull-unit-test-next-gen

ti-chi-bot · 2025-10-27T12:04:12Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [JmPotato,rleungx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MyonKeminta · 2025-10-27T12:06:07Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T12:09:25Z

/cherry-pick release-nextgen-20251011

ti-chi-bot · 2025-10-27T12:09:28Z

@rleungx: once the present PR merges, I will cherry-pick it on top of release-nextgen-20251011 in the new PR and assign it to you.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

rleungx · 2025-10-27T12:17:58Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T12:33:25Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T12:46:36Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T13:26:36Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T13:35:29Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T13:49:03Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T13:56:49Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T14:04:22Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T14:14:33Z

/test unit-test

ti-chi-bot · 2025-10-27T14:14:36Z

@MyonKeminta: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-build

/test pull-build-next-gen

/test pull-check-deps

/test pull-error-log-review

/test pull-integration-realcluster-test

/test pull-unit-test-next-gen

The following commands are available to trigger optional jobs:

/test pull-integration-copr-test

/test pull-unit-test

Use /test all to run the following jobs that were automatically triggered:

pull-build

pull-build-next-gen

pull-check-deps

pull-error-log-review

pull-unit-test-next-gen

tikv/pd/pull_integration_realcluster_test

Details

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

MyonKeminta · 2025-10-27T14:14:42Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T14:27:33Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T15:21:42Z

/test pull-unit-test-next-gen

rleungx · 2025-10-27T15:52:12Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-27T16:37:29Z

/test pull-unit-test-next-gen

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

MyonKeminta · 2025-10-27T17:49:29Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-28T02:47:48Z

/test pull-unit-test-next-gen

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

MyonKeminta · 2025-10-28T02:58:39Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-28T03:19:00Z

/test pull-unit-test-next-gen

MyonKeminta · 2025-10-28T03:31:06Z

/test pull-unit-test-next-gen

ti-chi-bot · 2025-10-28T04:13:21Z

@rleungx: new pull request created to branch release-nextgen-20251011: #9878.

Details

In response to this:

/cherry-pick release-nextgen-20251011

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

close #8978 As keyspace ID is hidden in metrics and hidden to users, printing keyspace ID in logs might not help in diagnosing. This PR adds keyspace name field to the logs of the GC state manager, while still keeping the keyspace ID in the logs. Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com> Co-authored-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

gc: Add keyspace name to logs

46c8062

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 27, 2025

fix test

fa7f821

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

MyonKeminta changed the title ~~gc: Add keyspace name to logs~~ gc: Add keyspace name to logs about GC Oct 27, 2025

rleungx approved these changes Oct 27, 2025

View reviewed changes

ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 27, 2025

okJiang approved these changes Oct 27, 2025

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 27, 2025

make lint happy

bf39cc4

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

JmPotato approved these changes Oct 27, 2025

View reviewed changes

skip flaky test

411d259

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

skip flaky test

0c4a973

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>

ti-chi-bot bot merged commit e2c8bf5 into tikv:master Oct 28, 2025
29 checks passed

ti-chi-bot mentioned this pull request Oct 28, 2025

gc: Add keyspace name to logs about GC (#9875) #9878

Merged

Conversation

MyonKeminta commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

Uh oh!

ti-chi-bot bot commented Oct 27, 2025

[LGTM Timeline notifier]

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

ti-chi-bot bot commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

ti-chi-bot commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

ti-chi-bot bot commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

rleungx commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 27, 2025

Uh oh!

MyonKeminta commented Oct 28, 2025

Uh oh!

MyonKeminta commented Oct 28, 2025

Uh oh!

MyonKeminta commented Oct 28, 2025

Uh oh!

MyonKeminta commented Oct 28, 2025

Uh oh!

Uh oh!

ti-chi-bot commented Oct 28, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

MyonKeminta commented Oct 27, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading