Skip to content

gc: Add keyspace name to logs about GC (#9875)#9878

Merged
ti-chi-bot[bot] merged 4 commits intotikv:release-nextgen-20251011from
ti-chi-bot:cherry-pick-9875-to-release-nextgen-20251011
Oct 28, 2025
Merged

gc: Add keyspace name to logs about GC (#9875)#9878
ti-chi-bot[bot] merged 4 commits intotikv:release-nextgen-20251011from
ti-chi-bot:cherry-pick-9875-to-release-nextgen-20251011

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

This is an automated cherry-pick of #9875

What problem does this PR solve?

Issue Number: Close #8978

What is changed and how does it work?

As keyspace ID is hidden in metrics and hidden to users, printing keyspace ID in logs might not help in diagnosing. This PR adds keyspace name field to the logs of the GC state manager, while still keeping the keyspace ID in the logs.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)
image

Code changes

-

Side effects

  • Increased code complexity

Related changes

Release note

None.

Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
Signed-off-by: MyonKeminta <MyonKeminta@users.noreply.github.com>
@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011 labels Oct 28, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 28, 2025

Codecov Report

❌ Patch coverage is 86.66667% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.65%. Comparing base (5bbec7c) to head (f05da89).
⚠️ Report is 3 commits behind head on release-nextgen-20251011.

Additional details and impacted files
@@                     Coverage Diff                      @@
##           release-nextgen-20251011    #9878      +/-   ##
============================================================
- Coverage                     78.73%   78.65%   -0.08%     
============================================================
  Files                           491      491              
  Lines                         65896    66115     +219     
============================================================
+ Hits                          51880    52004     +124     
- Misses                        10340    10416      +76     
- Partials                       3676     3695      +19     
Flag Coverage Δ
unittests 78.65% <86.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MyonKeminta
Copy link
Copy Markdown
Contributor

/test pull-unit-test-next-gen

@rleungx
Copy link
Copy Markdown
Member

rleungx commented Oct 28, 2025

/override pull-unit-test-next-gen

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

@rleungx: Overrode contexts on behalf of rleungx: pull-unit-test-next-gen

Details

In response to this:

/override pull-unit-test-next-gen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@MyonKeminta
Copy link
Copy Markdown
Contributor

/merge

@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

@MyonKeminta: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want to approve this pull request.

The changes announcement: LGTM plugin changes

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 28, 2025
@ti-chi-bot
Copy link
Copy Markdown
Contributor

ti-chi-bot bot commented Oct 28, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-28 05:22:58.280731833 +0000 UTC m=+1367684.357984383: ☑️ agreed by rleungx.
  • 2025-10-28 05:34:27.620431929 +0000 UTC m=+1368373.697684489: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit cd65c89 into tikv:release-nextgen-20251011 Oct 28, 2025
24 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-9875-to-release-nextgen-20251011 branch October 28, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-nextgen-20251011

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants