fix(ed25519): Add a check for NativeAmount to be non-negative#4663
Merged
sergei-boiko-trustwallet merged 2 commits intomasterfrom Mar 6, 2026
Merged
fix(ed25519): Add a check for NativeAmount to be non-negative#4663sergei-boiko-trustwallet merged 2 commits intomasterfrom
NativeAmount to be non-negative#4663sergei-boiko-trustwallet merged 2 commits intomasterfrom
Conversation
Copilot started reviewing on behalf of
sergei-boiko-trustwallet
February 24, 2026 16:13
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds validation to prevent negative XRP amounts in the NativeAmount type. The validation ensures that XRP native amounts conform to the XRP ledger specification, which requires amounts to be non-negative. This is consistent with the encoding logic that sets a positive sign bit when serializing amounts.
Changes:
- Added a negative value check in
NativeAmount::newto reject amounts less than zero - Added a test case to verify negative amounts are properly rejected
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Binary size comparison➡️ aarch64-apple-ios: 14.34 MB ➡️ aarch64-apple-ios-sim: 14.34 MB ➡️ aarch64-linux-android: - 18.77 MB
+ 18.77 MB +1 KB➡️ armv7-linux-androideabi: - 16.20 MB
+ 16.20 MB +1 KB➡️ wasm32-unknown-emscripten: - 13.68 MB
+ 13.68 MB +1 KB |
nikhil-gupta-tw
approved these changes
Feb 27, 2026
erdemaslan-tw
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves validation for XRP amounts in the
NativeAmounttype by adding a check to prevent negative values, and updates the associated tests to cover this new validation.Validation improvements:
NativeAmount::newconstructor to return an error if a negative amount is provided, ensuring that XRP amounts cannot be negative.Testing: