Skip to content

fix(ed25519): Add a check for NativeAmount to be non-negative #4663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergei-boiko-trustwallet merged 2 commits into from
Mar 6, 2026
Merged

fix(ed25519): Add a check for NativeAmount to be non-negative #4663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09dabd7
fix(ed25519): Add a check for `NativeAmount` to be non-negative
sergei-boiko-trustwallet Feb 24, 2026
611e8a6
Merge branch 'master' into fix/xrp-amount
sergei-boiko-trustwallet Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions rust/chains/tw_ripple/src/types/amount/native_amount.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@ pub struct NativeAmount(i64);

impl NativeAmount {
pub fn new(amount: i64) -> SigningResult<Self> {
if amount < 0 {
return SigningError::err(SigningErrorType::Error_invalid_params).context(format!(
"Invalid XRP amount must not be negative (found: {amount})"
));
}
if amount > MAX_DROPS {
return SigningError::err(SigningErrorType::Error_invalid_params).context(format!(
"Invalid XRP amount is too large (max: {MAX_DROPS} found: {amount})"
Expand Down Expand Up @@ -75,5 +80,6 @@ mod tests {
NativeAmount::from_str("1e20").expect_err("More than max supply");
NativeAmount::from_str("1e-7").expect_err("Contains decimals");
NativeAmount::from_str("1.234").expect_err("Contains decimals");
NativeAmount::from_str("-1").expect_err("Negative");
}
}
Loading
⚡