Issue #217 - Add GRPC keepalive to server/client#333
Issue #217 - Add GRPC keepalive to server/client#333mehstg wants to merge 3 commits intouswitch:masterfrom
Conversation
|
Hi thanks for this contribution, it would be nice if these grpc options could be configured by flags, having sane defaults is always good but if people need to tweak or turn off this functionality it would be good to have the option. |
pkg/server/gateway.go
Outdated
| RetryInterval = 10 * time.Millisecond | ||
| ) | ||
|
|
||
| var kacp = keepalive.ClientParameters{ |
There was a problem hiding this comment.
nit: I generally prefer to have variable names that are long and obvious instead of short and obscure, so keepAliveClientParams would be preferable over kacp.
I'm afraid this is probably a little beyond my limited golang skills. Happy for someone else to pick it up though. |
|
#337 is enough to replace this? |
This PR adds a keepalive between servers/clients ensuring connections are closed correctly in the case of ungraceful KIAM server termination.
For reference:
Kiam issue - #217
Go-GRPC issue: grpc/grpc-go#3206
Putting this forward for review. I am currently running this patch in our main development cluster with no ill effects. I am not a golang dev by any stretch of the imagination so am not sure of the knock on effects of enabling this.