This repository was archived by the owner on Mar 5, 2024. It is now read-only.
enable gRPC keepalive to detect dead TCP connections (#217)#337
Merged
Joseph-Irving merged 1 commit intouswitch:masterfrom Dec 6, 2019
mechpen:master
Merged
enable gRPC keepalive to detect dead TCP connections (#217)#337Joseph-Irving merged 1 commit intouswitch:masterfrom mechpen:master
Joseph-Irving merged 1 commit intouswitch:masterfrom
mechpen:master
Conversation
When a TCP connection dies, i.e. no more packet from peer, gRPC does not close the connection by default. We need to enable gRPC keepalive to detect and close dead TCP connections.
Joseph-Irving
approved these changes
Dec 6, 2019
Contributor
Joseph-Irving
left a comment
Joseph-Irving
left a comment
There was a problem hiding this comment.
thanks for this PR, hopefully this will solve some people's issues!
LGTM!
|
What are the chances of releasing a new version with these changes? |
This was referenced Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a TCP connection dies, i.e. no more packet from peer, gRPC
does not close the connection by default. We need to enable gRPC
keepalive to detect and close dead TCP connections.