feat(i18n): added i18next for user interface translations #432
feat(i18n): added i18next for user interface translations #432priscilawebdev merged 4 commits intomasterfrom
Conversation
priscilawebdev
changed the title
juanpicado
left a comment
juanpicado
left a comment
There was a problem hiding this comment.
Great stuff @priscilawebdev , looking forward we can test it with Verdaccio core.
I've notice few strings are not translated, but nothing big :)
| </WrapperLink> | ||
| </Grid> | ||
| <GridRightAligned item={true} xs={true}> | ||
| <GridRightAligned alignItems="center" container={true} item={true} justify="flex-end" xs={true}> |
There was a problem hiding this comment.
Does this PR requires change this alignItems="center" container={true} item={true} justify="flex-end" xs={true}>?
There was a problem hiding this comment.
yes! it was necessary to do this changes
| @@ -1,14 +0,0 @@ | |||
| /* eslint-disable max-len */ | |||
There was a problem hiding this comment.
I may be mistaken, but I couldn't find where it is being used
| })); | ||
|
|
||
| jest.mock('i18next', () => { | ||
| const translationEN = require('../../i18n/translations/en-US.json'); |
There was a problem hiding this comment.
Do we need this? I don't see the connection with the test.
There was a problem hiding this comment.
in fact they have a connection ... I'm using the English translation file to do the tests ... I didn't want to write consts or a string ... I think it's better if we reuse it ... so let's say I don't I want more "Login", but "Sign in" .. if the id's remained the same (en translations) and only the value changes, we don't need to update the tests
| }); | ||
|
|
||
| new WebpackDevServer(compiler, { | ||
| contentBase: `${env.DIST_PATH}`, |
There was a problem hiding this comment.
we don't need to wrap it in a string literal. it's the same but without ``
priscilawebdev
force-pushed
the
feature/102_added_i18next
branch
from
7366660 to
4467be9
Compare
|
@juanpicado yes, some words are not being translated, because either they are come from backend as a value, like "JS foundation and contributors", or from a library, '2 years ago' and I need to fix it ...please see:
|
priscilawebdev
changed the title
ok, if comes from the backend, we will fix that later, thanks for letting me know :) |
priscilawebdev
force-pushed
the
feature/102_added_i18next
branch
from
4467be9 to
76e8a02
Compare
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
==========================================
- Coverage 88.45% 88.08% -0.38%
==========================================
Files 137 140 +3
Lines 953 982 +29
Branches 196 204 +8
==========================================
+ Hits 843 865 +22
- Misses 99 106 +7
Partials 11 11
|
priscilawebdev
force-pushed
the
feature/102_added_i18next
branch
from
76e8a02 to
a0c0186
Compare
priscilawebdev
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for your PR, the @verdaccio/ui package will be accessible from here for testing purposes: |
priscilawebdev
changed the title
3 participants
Type: Feat
The following has been addressed in the PR: #102
Yes they are fixed, but it seems that I need to fix e2e tests now