This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fixing typography bug#195
Closed
jfamousket wants to merge 6 commits intoverdaccio:masterfrom
jfamousket:193_wrong_test_on_registry_info
Closed
fixing typography bug#195jfamousket wants to merge 6 commits intoverdaccio:masterfrom jfamousket:193_wrong_test_on_registry_info
jfamousket wants to merge 6 commits intoverdaccio:masterfrom
jfamousket:193_wrong_test_on_registry_info
Conversation
…jfamousket/ui into 193_wrong_test_on_registry_info
…jfamousket/ui into 193_wrong_test_on_registry_info
…jfamousket/ui into 193_wrong_test_on_registry_info
Member
|
I think you need to update snapshots |
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
=======================================
Coverage 88.73% 88.73%
=======================================
Files 117 117
Lines 932 932
Branches 168 168
=======================================
Hits 827 827
Misses 89 89
Partials 16 16
|
Contributor
|
@jfamousket Thank you much for your contribution 👏💪but, it seems that another contributor has already fixed the issue in this PR:: #196 I doubled checked and it is fine..please see:
|
Contributor
|
@jfamousket I'm sorry, but since this issue has been resolved and it has been a while ... I am closing this PR 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type:
The following has been addressed in the PR:
fixing wrong test on registry info
Description:
Resolves #193