This repository was archived by the owner on Jan 16, 2022. It is now read-only.
fix: changes font size for items of the register-info component#196
Merged
juanpicado merged 3 commits intoverdaccio:masterfrom Oct 15, 2019
smithandrewl:typography_fix
Merged
fix: changes font size for items of the register-info component#196juanpicado merged 3 commits intoverdaccio:masterfrom smithandrewl:typography_fix
juanpicado merged 3 commits intoverdaccio:masterfrom
smithandrewl:typography_fix
Conversation
This changes the font size for items of the register-info component to 1rem
Fixes #193.
Member
|
Please run |
Codecov Report
@@ Coverage Diff @@
## master #196 +/- ##
=========================================
Coverage ? 88.73%
=========================================
Files ? 117
Lines ? 932
Branches ? 168
=========================================
Hits ? 827
Misses ? 89
Partials ? 16
|
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: bug
Description: This changes the font size for items of the register-info component to 1rem. Using the inspector tool, the visible difference between the "correct" and "incorrect" versions of the register-info components was the font size. The correct/before component had a font-size of 1rem. This change sets the font size back to 1rem and the text is no longer cut-off at the bottom.
Resolves #193