Skip to content
This repository was archived by the owner on Jan 16, 2022. It is now read-only.

feat: Add french language + minor english language fix#459

Merged
juanpicado merged 2 commits intoverdaccio:masterfrom
liamjack:i18n_fr
Apr 17, 2020
Merged

feat: Add french language + minor english language fix#459
juanpicado merged 2 commits intoverdaccio:masterfrom
liamjack:i18n_fr

Conversation

@liamjack
Copy link
Copy Markdown
Contributor

Type: translation

The following has been addressed in the PR:

  • There is a related issue? No
  • Unit or Functional tests are included in the PR: No

Description:

Adds french translation and fixes minor mistakes in english translation

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2020

Codecov Report

Merging #459 into master will decrease coverage by 0.24%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   84.47%   84.22%   -0.25%     
==========================================
  Files         141      141              
  Lines        1011     1014       +3     
  Branches      210      210              
==========================================
  Hits          854      854              
- Misses        124      127       +3     
  Partials       33       33              
Impacted Files Coverage Δ
i18n/config.ts 100.00% <ø> (ø)
src/App/load-dayjs-locale.ts 25.92% <0.00%> (-3.25%) ⬇️

Copy link
Copy Markdown
Member

@juanpicado juanpicado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !! Glad to see a new language. Few things are missing, please review #448 and update remaining files and we are done 👍

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@liamjack
Copy link
Copy Markdown
Contributor Author

@juanpicado All done :)

@juanpicado juanpicado merged commit b173684 into verdaccio:master Apr 17, 2020
@juanpicado
Copy link
Copy Markdown
Member

Thanks @lgaitan !! It will be available in 4.6.0 and check out #456 which make will be even more visible

@liamjack liamjack deleted the i18n_fr branch April 18, 2020 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants