This repository was archived by the owner on Jan 16, 2022. It is now read-only.
feat: api provider and config provider#608
Merged
juanpicado merged 17 commits intomasterfrom Mar 19, 2021
Merged
Conversation
juanpicado
commented
Mar 13, 2021
Codecov Report
@@ Coverage Diff @@
## master #608 +/- ##
==========================================
- Coverage 79.53% 79.39% -0.14%
==========================================
Files 165 167 +2
Lines 1285 1330 +45
Branches 233 227 -6
==========================================
+ Hits 1022 1056 +34
- Misses 223 232 +9
- Partials 40 42 +2
|
juanpicado
changed the title
juanpicado
commented
Mar 14, 2021
9 tasks
remove VERDACCIO_BASENAME remove VERDACCIO_SCOPE remove VERDACCIO_LOGO
Contributor
|
I left some suggestions, but you did a really great job 🚀 |
Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
Co-authored-by: Priscila Oliveira <priscilawebdev@gmail.com>
priscilawebdev
approved these changes
Mar 19, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Introduce two new providers,
AppConfigurationContextwhich holds the variables which are embedded at the html, then usingconst { configOptions } = useConfig();via context can easily access each property.APIProviderwhich provides all API methods, one single place to rule all request instead have different references to API in different files eg:const { callDetailPage, callReadme } = useAPI();.window.__VERDACCIO_BASENAME_UI_OPTIONSto rule all options, remove old global variablesThis is part of verdaccio/verdaccio#2122